add inquiry check length#193
Closed
ayedm1 wants to merge 1 commit intoeclipse-threadx:masterfrom
ayedm1:storage_inquiry_length_check
Closed
add inquiry check length#193ayedm1 wants to merge 1 commit intoeclipse-threadx:masterfrom ayedm1:storage_inquiry_length_check
ayedm1 wants to merge 1 commit intoeclipse-threadx:masterfrom
ayedm1:storage_inquiry_length_check
Conversation
Contributor
|
@eclipse-threadx/iot-threadx-committers Please review this pull request. |
fdesbiens
added
the
discussion
rahmanih
requested changes
May 6, 2025
Contributor
There was a problem hiding this comment.
Hi @ayedm1,
Could you please restore the coding style to its original format and keep only the changes related to the commit. to have it clearer for review.
also please split into 2 PRs.
- add check length for inquiry page code
- update vendor id for "AzureRTO" to "Eclipse "
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add check length for inquiry page code
update vendor id for "AzureRTO" to "Eclipse "